Code efficiency with regard to computing resources

[Fledermaus]

Code: Select all

native AddSpecialEffect takes string modelName, real x, real y returns effect

You need to clean up that effect though. Depending on the model, you may be able to do this

Code: Select all

call DestroyEffect(AddSpecialEffect(somemodelname, x, y))

in your case this should work:

Code: Select all

call DestroyEffect(AddSpecialEffect("Abilities\\Spells\\Human\\ThunderClap\\ThunderClapCaster.mdl", GetUnitX(GetEnumUnit()), GetUnitY(GetEnumUnit())))

You should probably make a local unit to store GetEnumUnit() in (remember to null it at the end of the function) so you only have to call it once. Depending on what else you are doing, you may also want to make the x and y local reals.

[Greenspawn]

Cool. What about when creating units at a target location?

[Rising_Dusk]

The location leaks. It always leaks if you don't call RemoveLocation() on it.

[Fledermaus]

There is only 1 time you should ever use a location, when you need to use GetLocationZ. Otherwise you can always use coordinates instead.

[Greenspawn]

Ok cool

CreateUnit returns a unit, but all i have to do is remove it from the game right?

[Rising_Dusk]

If a unit dies, the game naturally removes it after its decay time. (So you don't have to)

[Greenspawn]

Ok. I just stumbled across another issue: what if you need to know where a certain ability was targeted (i.e. GetSpellTargetLoc()). Is there a way to do this in X,Y without using the location?

[2-P]

Not sure, but I think GetSpellTargetX/Y was added in the 1.24 patch.

[Rising_Dusk]

They were.

[Greenspawn]

Thanks!